search

ludwig-cf / ludwig

A lattice Boltzmann code for complex fluids
https://ludwig.epcc.ed.ac.uk
Other
52 stars 35 forks source link

Remove `io_harness.[ch]` #284

Closed kevinstratford closed 1 month ago

kevinstratford commented 11 months ago

The i/o code in io_harness.[ch] should be replaced by the new i/o mechanism in

This will allow io_harness.[ch] and associated code to be removed. It will also eliminate a number of current security alerts for uncontrolled data in path expression.

kevinstratford commented 1 month ago

Comment on the order parameter noise tests in the advent of single noise generator.

Test serial-spin-n01.inp is still valid as it had only order parameter noise (no density fluctuations) with equivalent initialisation.

Test serial-spin-n02.inp is no longer valid as this had both order parameter noise and density noise, giving rise to different results.

Test serial-spin-fd3.inp was defective in that it did not correctly pick up symmetric_noise. This will be replaced by better documented alternatives.