lue-bird / elm-review-missing-record-field-lens

elm-review: helper generation
https://package.elm-lang.org/packages/lue-bird/elm-review-missing-record-field-lens/latest/
MIT License
2 stars 1 forks source link

add `RecordFieldLensGenerator` for `erlandsona/elm-accessors` named #4

Closed lue-bird closed 2 years ago

lue-bird commented 2 years ago

Add a default generator for @erlandsona 's named Accessors. Have a generator like this lying around? → PR

lue-bird commented 2 years ago

Plus, how should it be called?

erlandsona commented 2 years ago

So my thought is these are part of the same package / namespace because they're all "Optics" I couldn't think of how to merge the two under the same namespace but if you have any ideas that's my ideal. Otherwise, it's just a separate rule that gets added to the list of rules that I run on a watcher 🤷‍♂️

erlandsona commented 2 years ago

Have a generator like this lying around? → PR

Isn't that what I PR'd before? not sure what you mean?

lue-bird commented 2 years ago

It's about RecordFieldLensGenerators as the title suggests: the current field accessor is unnamed and annotated with Relations. My question was whether changing the implementation under the hood is fine and whether an unnamed version should be added (or rather, how that one should be called)

lue-bird commented 2 years ago

Fixed by