lue-bird / elm-review-missing-record-field-lens

elm-review: helper generation
https://package.elm-lang.org/packages/lue-bird/elm-review-missing-record-field-lens/latest/
MIT License
2 stars 1 forks source link

add `VariantPrismGenerator` for `elm-accessors` unnamed #5

Closed lue-bird closed 2 years ago

lue-bird commented 2 years ago

The default VariantPrismGenerator named accessors generates named Accessors by @erlandsona. The unnamed version is for users of bChiquet/elm-accessors or those should help transition to named erlandsona/elm-accessors.

erlandsona commented 2 years ago

My version is fully backwards compatible with bChiquet's... so there shouldn't be anything that prevents people from trying out my version which just has more accessors built in.

erlandsona commented 2 years ago

The named vs unnamed is mostly irrelevant until I figure out the rest of this Form abstraction I've been doing all of this to support.

lue-bird commented 2 years ago

But the named and unnamed accessor types are not compatible, right? → The current, named versions are only compatible with your package

erlandsona commented 2 years ago

But the named and unnamed accessor types are not compatible, right?

They ARE compatible. This is what I've been trying to say. I explicitly made them all backwards compatible.

lue-bird commented 2 years ago

Nah, we're still talking past each other. Defining the variant prisms by Accessors.makeOneToN_ which is what you PRed and what I'd like to keep as the default is only available in your package, not in bChiquets. Only the unnamed version is working with either package → this issue will keep me reminded to add such an unnamed version.

erlandsona commented 2 years ago

Ah yup, got it. Correct. I'm using the "extended" version for generating lenses with unique names but my version of the package keeps the same module heirarchy as bChiquets so the generator for the unnamed version should still work for both packages.

👌

lue-bird commented 2 years ago

Added VariantPrism.GenerateUsed.accessorsBChiquet