lue-bird / elm-review-missing-record-field-lens

elm-review: helper generation
https://package.elm-lang.org/packages/lue-bird/elm-review-missing-record-field-lens/latest/
MIT License
2 stars 1 forks source link

Touchup accessors codegen to autogenerate names for Lenses. #6

Closed erlandsona closed 2 years ago

erlandsona commented 2 years ago

RE: issue #4

erlandsona commented 2 years ago

Feel free to keep or nuke this... We use this generator at work but the old version should work out of the box with no changes I think 👍

lue-bird commented 2 years ago

Looks fine to me. Keep the PRs flowing!

Like for variant prisms #5, I'd still like to keep an unnamed version around for those using bChiquet's version and I was asking for a name for it in issue #4 you mentioned... Ok, let's override the implementation of accessors with the named version. There aren't any users outside of { you }, so it shouldn't break anyone's code badly.

I'll merge this soon enough. If you see this before I have merged it, please

and if you feel especially motivated:

erlandsona commented 2 years ago

There aren't any users outside of { you }, so it shouldn't break anyone's code badly. 😅 And I may or may not get back to this before the weekend and it's not a blocker so feel free to merge or otherwise as you see fit 👍