search

lueckenlab / patpy

BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Inconsistent interface #68

Open VladimirShitov opened 1 month ago

VladimirShitov commented 1 month ago

Report

scPoli wrapper stores patient embeddings in the patient_representation slot, while other methods (and the main class) have it in patient_representations. The former sounds better, to be honest. We should standardise it.

Version information

No response

VladimirShitov commented 1 month ago

Thanks! Let's use this PR to clean up the code. We should then increase the major version because API will break, so better to do all at once. I'll add some changes soon