Open farhadmd7 opened 1 month ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
@mumichae , could you take a look at the refactored interface? Main changes are:
CellTypesComposition
-> CellGroupComposition
CellTypePseudobulk
-> GroupedPseudobulk
patient_representation
argument is renamed to sample_representation
SampleRepresentation
instead of PatientRepresentation
. This is important only for developers, users shouldn't use it anywayOther changes:
SCellBow
classWe need to do a bit more refactoring:
tl/basic.py
to tl/sample_representation.py
patient_representation
directory, and the entire package to patpy
Let's do it in a separate PR later because now it would create merge conflicts with other branches
I just left a review.
Geberal comment that I didn't address in the review: Do you want to eventually split the tl._basic file into a file per method to keep the code more readable? Would that be something for a new Pull Request?
I just left a review.
Geberal comment that I didn't address in the review: Do you want to eventually split the tl._basic file into a file per method to keep the code more readable? Would that be something for a new Pull Request?
Thank you! I agree that splitting or at least renaming the file makes sense, and we'll definitely do it later. But now, when we have development ongoing in several branches, it will create merge conflicts
Thanks! Let's actually use this branch to clean up the code. Changing an argument name breaks the API anyway, so let's fix other stuffs as well, and then update the major version. I'll push some changes soon