lueckenlab / patpy

BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Refactor interface #69

Open farhadmd7 opened 1 month ago

VladimirShitov commented 1 month ago

Thanks! Let's actually use this branch to clean up the code. Changing an argument name breaks the API anyway, so let's fix other stuffs as well, and then update the major version. I'll push some changes soon

review-notebook-app[bot] commented 1 month ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

VladimirShitov commented 1 month ago

@mumichae , could you take a look at the refactored interface? Main changes are:

Other changes:

VladimirShitov commented 1 month ago

We need to do a bit more refactoring:

Let's do it in a separate PR later because now it would create merge conflicts with other branches

mumichae commented 1 month ago

I just left a review.

Geberal comment that I didn't address in the review: Do you want to eventually split the tl._basic file into a file per method to keep the code more readable? Would that be something for a new Pull Request?

VladimirShitov commented 1 month ago

I just left a review.

Geberal comment that I didn't address in the review: Do you want to eventually split the tl._basic file into a file per method to keep the code more readable? Would that be something for a new Pull Request?

Thank you! I agree that splitting or at least renaming the file makes sense, and we'll definitely do it later. But now, when we have development ongoing in several branches, it will create merge conflicts