search

luetage / vivaldi_modding

Custom modifications for Vivaldi web browser.
MIT License
81 stars 6 forks source link

Actviate Tab on Hover - Please make it working in tab stacks #6

Closed N3C2L closed 3 years ago

N3C2L commented 3 years ago

Hello,

Can you update the script to work in tab stacks? Much appreciated. Regards

luetage commented 3 years ago

Which script? You are raising an issue for the whole project, I cannot know which mod you are referring to.

N3C2L commented 3 years ago

Sorry. It is about the activate tab on hover script. I reopened the issue and changed title.

luetage commented 3 years ago

So I took a look at it. The mod works by updating the hovered tab and making it active by checking its id and invoking chrome.tabs api. The problem is chrome.tabs requires the id to be a number and the parent tab of stacked tabs doesn’t have a number but a string with mixed letters and numbers, which chrome.tabs doesn’t accept. Why Vivaldi did this I don’t know, it’s definitely not standard, but I currently see no easy way to solve the issue.

N3C2L commented 3 years ago

Thanks for looking into it. Maybe you have an idea someday for solving it.

luetage commented 3 years ago

I implemented an ugly solution, but it’s necessary, the click for the parent stack is being simulated now. Seems to work, tell me whether you have issues with this. Gonna close this now.