luetage / vivaldi_modding

Custom modifications for Vivaldi web browser.
MIT License
81 stars 6 forks source link

Activate Tab on Hover - Problem in vertical tab bar #7

Closed N3C2L closed 3 years ago

N3C2L commented 3 years ago

Thanks again for the tab stack update. Works fine. However, I have another problem. If you activate the vertical tab bar (e.g. left) and then move the mouse pointer all the way to the left edge of the screen and move the mouse up and down between the tabs, the tabs will not activate by hover. But if you click with the mouse, these tabs get activate. I don't know if it's because of my browser.

luetage commented 3 years ago

Hey, just tried it and can’t reproduce. It doesn’t make much sense, because the event listeners are on the tabs and get triggered whenever you hover them. Clicking or dragging outside can’t deactivate them. No idea what’s going on on your end, but I won’t be able to fix it.

N3C2L commented 3 years ago

Thanks. Hmm. When I put the tab bar above the adress bar it works if I move the mouse pointer alle the way up to the screen and between the tabs. At first I thought it was caused by the fact that I have a high zoom level of 200% in Windows 10 (because my monitor is far away). But that is not the cause. Switchted to 125% same problem. But my UI zoom level in Vivaldi is set to 90%. Does not change the vertical tabs switching problem if I increase or decrease the zoom level. Need to investigate further..

N3C2L commented 3 years ago

2021-03-16 14_45_46-Greenshot

Look at the pic. Do you also have this margin to the left of the tab? I think this margin is the reason why it will not activate the tab if the cursor is far left in the screen like in my picture.

N3C2L commented 3 years ago

Can you add some CSS into your javascript that removes this left margin from tabs/tab bar? So that new user of the this script will not ask for this question again.

luetage commented 3 years ago

Didn’t know you aren’t showing the panel. I disabled my panel, made the tabs small like yours and tried again. I have zero issues. You will have to come up with a solution yourself.

luetage commented 3 years ago

Maybe someone on Vivaldi Forum can help you, or at least reproduce. Please follow the link on top of the mod and make a post there.

N3C2L commented 3 years ago

Ok, just to clarify:

  1. you do not have this margin and it is working or
  2. you have this margin and it is working?
  3. if you move the cursor from one left margin of a tab straight above to the next left margin of a tab, the tab gets activated with hovering?
luetage commented 3 years ago

Around the edge my cursor changes shape and is ready to resize the window, this cannot trigger the mod and I do not consider it a bug. Should the margin make trouble for you, you can of course remove it with CSS, you don’t need Javascript.

N3C2L commented 3 years ago

If the Vivaldi window is maximized then the cursor does not change into resize. At least on Windows 10. Maybe you are on another OS and there is another behavior. On my pic above you see a cutout of the maximized window and the cursor is at the left edge of the screen, no cursor change into resize.

luetage commented 3 years ago

I’m on Linux and not questioning your issue, but you have to understand that it’s a very specific and personal one, no one but you needs that change. Removing the margin alters Vivaldi’s looks and I’m not willing to change it for everyone else. My suggestion is you create a custom.css file and remove the margin. Here a guide how to inspect the UI: https://forum.vivaldi.net/topic/16684/inspecting-the-vivaldi-ui-with-devtools

N3C2L commented 3 years ago

Yes, I know it can be cut with css. But I thought that you may have a better solution. When you click with the left mouse button in this left margin outside the tab it gets activated, but not if you hover over them. So I just wondered why you can click outside there and the tab gets activated.. there must something trigger these tabs in this margin with the mouse click that your hoverscript not detect as tab area..

luetage commented 3 years ago

The click probably bubbles through. I won’t do anything about this.

N3C2L commented 3 years ago

OK I will close this now, unsolved, maybe someday you will emulate Windows 10 for users who have problems there.