lufinkey / iSSB

A cross-platform "Super Smash Bros. Brawl" fan-game
http://cydia.saurik.com/package/com.brokenphysics.issb/
39 stars 12 forks source link

cydia release? #19

Open Alekemon opened 3 years ago

Alekemon commented 3 years ago

idk, just making sure if corneria was enough for a new update

lufinkey commented 3 years ago

I'll look into maybe updating it in Cydia, but I have no control over the distribution anywhere else, like BuildStor. It's up to those sites if they want to recompile it with the updates.

lufinkey commented 3 years ago

I also don't really want to push an update and give a bunch of people the impression that I'm gonna be updating this regularly. If you want to keep updating it I can push an update, but I don't really want to keep having to do work for this app. I just have a lot of other stuff I'm trying to spend my time on and I don't want to keep having to pull down and test the app, correct changes, build releases, etc.

Alekemon commented 3 years ago

Yeah, I'm now working on more characters and more stages, as well as a classic mode (but that's gonna take long). I can keep up with iSSB perfectly.

Alekemon commented 3 years ago

So please, will you post the update? I'll update regularly

lufinkey commented 3 years ago

If you add end up adding a decent amount more then I will but right now I just have a lot going on.

If you're really serious about adding more content I can try to put together a PR checklist for when you make changes. I'd really recommend learning how to create a new branch in git so you can manage different changes separately. The thing that will probably speed things up the most when you make a PR is if you're willing to attach video/gifs and screenshots showing the character or stage working, showing where the wireframe regions / boundaries are, all the different moves in different ways etc so I don't have to necessarily load the game up myself and test everything a bunch to make sure it works right.

It's really cool that you're interested in contributing and i definitely want to push releases if you're willing to contribute more, I'd just rather push those changes as one or two releases in bulk, that way it can be fully tested and adjusted and all of that, and doing that takes time.

Alekemon commented 3 years ago

how much characters and stages are necessary for one update more or less?

lufinkey commented 3 years ago

How many characters or stages were you planning on adding? I feel like 3 is probably a good number of characters before I'd feel compelled to update, but are you willing to fully test them, make adjustments to the sprites, discuss movesets beforehand etc? Bc I don't wanna just take Sprite rips and shove them into the game. I'd really want any new characters to feel stable and well playable.

Alekemon commented 3 years ago

Sure, I'm planning to add Samus, Jigglypuff and Mega Man. But fully playable with new movesets.

lufinkey commented 3 years ago

When you say new movesets, do you mean different than the ones in the smash games? Because I kinda think for the most part for existing characters we should stick to the moveset from the games. I'm definitely open to making it different, but only really if it's for a real reason.

On Sun, Oct 3, 2021, 2:10 PM Alekemon @.***> wrote:

Sure, I'm planning to add Samus, Jigglypuff and Mega Man. But fully playable with new movesets.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/lufinkey/iSSB/issues/19#issuecomment-932999406, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB3VGUI5KWS7X6RDHGDYIB3UFCMDHANCNFSM5FAQKCKA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

lufinkey commented 3 years ago

At the very least for the characters in Brawl or before. After brawl I don't mind as much since the roster gets a little crazy

Alekemon commented 3 years ago

I meant movesets that aren't clones of already existing characters in iSSB

lufinkey commented 3 years ago

Oh awesome. So they match the smash games?

On Mon, Oct 4, 2021, 10:48 AM Alekemon @.***> wrote:

I meant movesets that aren't clones of already existing characters in iSSB

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/lufinkey/iSSB/issues/19#issuecomment-933560935, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB3VGUPRPJIOCMJ7OSKCWZLUFG5EZANCNFSM5FAQKCKA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Alekemon commented 3 years ago

Of course

lufinkey commented 3 years ago

Nice

On Mon, Oct 4, 2021, 11:31 AM Alekemon @.***> wrote:

Of course

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/lufinkey/iSSB/issues/19#issuecomment-933601552, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB3VGUJDK3CHZUESJTSNSFDUFHCDLANCNFSM5FAQKCKA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

lufinkey commented 3 years ago

btw, you don't need to re-fork iSSB every time. You can add this repo as a remote in the git command line (maybe call it lufinkey) and then just pull directly from the remote master. It'll update your branch directly

git remote add lufinkey https://github.com/lufinkey/iSSB.git
git pull lufinkey master