Closed nick-lehmann closed 3 years ago
Yeah go for it
Also I think the search
argument should probably be any
if you're gonna make it an empty object
Ok, I will give it a shot this week. Just another quick question: Would you like to stick with Javascript and I only add the types, or would it be acceptable to also rewrite the few lines of code to Typescript altogether?
Sorry forgot to respond to this. I think just adding the typing files would be fine
Sorry for the late response, but the pull request is now there. Did a very quick test in a sample project and it works as expected 👍🏻
It would be very beneficial for all who want to use this package in a typescript package to include types for all functions. Since your package works like a charm for me (thank you 🙏🏻), I have created a declaration file for your package and included it in my
tsconfig.json
.Would you be willing to accept a pull request to add the types to this package?
The current state (not completely done) can be seen below. If you would agree to a PR for adding these, I would spend a little bit of time on completing the types.
justwatch.d.ts
```typescript declare module "justwatch-api" { export default class JustWatch { constructor(options: any); _options: any; // request(method: any, endpoint: any, params: any): Promise