search

lufinkey / node-justwatch-api

Unofficial JustWatch API for nodejs
71 stars 14 forks source link

React Build Error - Failed to Minify #4

Closed yuschick closed 5 years ago

yuschick commented 6 years ago

First, let me say thanks for this API. Super helpful.

I am using this in a Create React App and when I try running yarn build I receive the following error:

Failed to minify the code from this file:
./node_modules/justwatch-api/index.js:7

The error directs me to the React Docs which provide this information:

npm run build fails to minify Some third-party packages don't compile their code to ES5 before publishing to npm. This often causes problems in the ecosystem because neither browsers (except for most modern versions) nor some tools currently support all ES6 features. We recommend to publish code on npm as ES5 at least for a few more years.

Any plans to update for this use case?

lufinkey commented 6 years ago

I don't exactly know what is ES5 or ES6 in my code. Could you elaborate on what's in the code preventing it from minifying? Is it the await/async stuff?

lufinkey commented 5 years ago

Are you still having this issue?

yuschick commented 5 years ago

@lufinkey I am not sure because I ended up switching to a different API and haven't really looked at the project since implementing that. You can close this. It's not holding anything up on my end.