Closed wilt00 closed 5 years ago
Changes made.
I'm pushing the is_current_student
query param to another PR, since that might need some extra logic around term dates.
We'll definitely split Officer out, but I think the way we want to do that is to give each API category (officers, events, etc) its own models/views/controllers. That's a big enough change that I think it deserves its own PR.
Alright. We can create another issue surrounding the file structure of the backend (in addition to the is_current_student
parameter) after this PR is merged.
Implements #12. Note that this implementation differs from #11 in the following ways:
Officer
objects now have the additional membersterm_start
andterm_end
, representing the start and end of their term of office. For a normal term of office, these run from Summer of one calendar year to Spring of the next, inclusive. These are stored in the formSEASON_YYYY
, e.g.SPRING_2018
./api/officers
provides the following query parameters:(Now I look at it,
is_current
is confusing, people might think it means "is currently serving" rather than "is currently a student".)Coming out of this, I'd like to get proper logging and testing set up, those would've been helpful when developing this. I'll make issues for those.