lugatuic / lug.cs.uic.edu-2018

https://lug.cs.uic.edu/
6 stars 2 forks source link

Officers API and data #31

Closed wilt00 closed 5 years ago

wilt00 commented 6 years ago

Implements #12. Note that this implementation differs from #11 in the following ways:

Coming out of this, I'd like to get proper logging and testing set up, those would've been helpful when developing this. I'll make issues for those.

wilt00 commented 5 years ago

Changes made. I'm pushing the is_current_student query param to another PR, since that might need some extra logic around term dates.

wilt00 commented 5 years ago

We'll definitely split Officer out, but I think the way we want to do that is to give each API category (officers, events, etc) its own models/views/controllers. That's a big enough change that I think it deserves its own PR.

BluuArc commented 5 years ago

Alright. We can create another issue surrounding the file structure of the backend (in addition to the is_current_student parameter) after this PR is merged.