search

lugensa / scorched

Sunburnt offspring solr client
MIT License
27 stars 19 forks source link

results_as() does nothing #27

Open Chronial opened 8 years ago

Chronial commented 8 years ago

Just found this bug while browsing the code: The results_as function ignores its keyword argument and just returns a copy of the query.

https://github.com/lugensa/scorched/blob/0074415e80a00c69f1b64e59f555ee2b2d3b4066/scorched/search.py#L550

since this function is also documented nowhere, maybe just remove it?

delijati commented 8 years ago

@lujh @lugensa are you using this in your code base? results_as

lugensa commented 8 years ago

Hi,

we do not use this in our code.

delijati commented 8 years ago

@Chronial feel free to remove that code and send a push request.