search

lugensa / scorched

Sunburnt offspring solr client
MIT License
27 stars 19 forks source link

Second approach at fixing issue 45 #47

Closed mlissner closed 7 years ago

mlissner commented 7 years ago

This is a second approach to fixing issue #45, since the last attempt got rather messy. This gets the whole thing into a single commit with one added method on BaseSearch, and a couple of simple tests.

I ran into one issue with the MLT functional tests, which weren't cleaning up after themselves, so I tweaked that too. Otherwise, I think this is a good, clean solution.

(As an aside, this is nearly identical to what we've been using in production for a few weeks.)

mlissner commented 7 years ago

FYI, the failing tests are related to the timeout error and httpbin. I didn't touch those tests, so I suspect httpbin is having issues or something along those lines.