search

lugg / react-native-config

Bring some 12 factor love to your mobile apps!
MIT License
4.82k stars 657 forks source link

Repo ownership & maintenance status – migrating to react-native-community or a new owner #382

Closed wamry closed 4 years ago

wamry commented 5 years ago

After going through tons of issues and trying every possible way to get this awful messy repo to work, I tried to work with this "https://github.com/luggit/react-native-config.git#89a602b" and the npm version, it just won't work, does anyone have have a stable fork that i can use ?

i'm using react-native 0.60.5

azamiya commented 5 years ago

I'm also looking for that problem. I tried to use react-native-dotenv, but it says

Can I have more than production & development environment configs? Sadly, it's not available so far. One of the workaround is generating .env file before triggering RN's bundle script automatically using either shell script or your own custom build pipeline.

divyanshunegi commented 5 years ago

I am getting the whole app frozen and button press does not work at all in one of the screen after using this library, need any kind of alternate, I am thinking to create a custom Native bridge anyway

macco-chewy commented 5 years ago

Have you followed the instructions in this issue? https://github.com/luggit/react-native-config/issues/365

LuizFBrisighello commented 5 years ago

Im on RN 0.60.5 and using react-native-config just to be able to use env:ENVFILE=".env" and react-native-build-config to expose the variables to my js.. nnot the best but its working for now.

Sathyanarayan09 commented 5 years ago

Check this article for an alternative https://medium.com/commutatus/multi-environment-variable-setup-for-react-native-application-70fde4de657f

atulmy commented 5 years ago

Considering the popularity and wide adoption, this project should be migrated to https://github.com/react-native-community

Javi commented 5 years ago

I think this library has been effectively abandoned. Any charitative souls willing to maintain a fork?

kelset commented 5 years ago

@atulmy I can facilitate making that happen, but the issue is that it seems that the maintainers are not responding to DMs or messages or pings in any way. If they want to reach out to me directly so that we can make this happen, pls DM me on twitter.

mvrdrew commented 5 years ago

Funny you should say that, I've opened this project:

https://github.com/x-react-native/env-config

Would dearly love some help to get it into shape so I can publish a new npm module asap!

gorhom commented 5 years ago

@atulmy I can facilitate making that happen, but the issue is that it seems that the maintainers are not responding to DMs or messages or pings in any way. If they want to reach out to me directly so that we can make this happen, pls DM me on twitter.

@kelset, @atulmy

any updates regarding moving this repo to react-native-community ?

mvrdrew commented 5 years ago

@Gorhom I've been in contact with @kelset about migrating my fork into react-native-community and it's all sounding very promising so far. @kelset is super busy this week though, so he's asked me to remind him about this next week when he has more time.

gorhom commented 5 years ago

@melodydrewvr thanks for the update 🎉, let me know if you need help in maintaining it :)

compojoom commented 5 years ago

@melodydrewvr - any progress? I've used this library previously on RN < 0.60 and it worked great. Just wanted to use it on a project with RN .61 and read about all the issues.

I was thinking of forking and fixing it for us, but if this is going to move to react-native-community I would love to help with that. @melodydrewvr - if you want let's connect and sync our efforts on this.

kelset commented 5 years ago

👋 folks - I've asked to the community owners and basically the conversation is about understanding the "overlap" between this lib and the react-native-dotenv alternative.

I've proposed a gradual roadmap that would lead to the two converging, as soon as I have a "final say" of some sort from their side I'll update @melodydrewvr & y'all - hopefully it won't be long.

compojoom commented 5 years ago

The overlap between react-native-config and react-native-dotenv is only on the javascript side, right? React-native-config on the other hand allows you to use your ENV variables both in objective-c code or in the java code. Ah, forgot gradle. So it is a little bit more powerful in my opinion.

pedro commented 5 years ago

hey folks! so sorry we dropped the ball here – I'm no longer working at Lugg and they are super busy with other stuff, but we'd all love to work with the community to find a new home and maintainers for this project.

@melodydrewvr @kelset let us know how can we help with the move to react-native-community!

I like how react-native-dotenv works more smoothly in js land, whereas with this plugin you need to recompile the app to see env changes. But being able to use that env in xcode/gradle/etc is really the most important feature here. I'm sure we could make this work better with js files or even merge the two projects if there's someone interested in taking the lead.

Thanks,

JanithaR commented 5 years ago

I am using react-native-config for nearly 3 years now and just a week ago got up on the fence to almost ditch it. And react-native-dotenv was the obvious choice but as @pedro mentioned,

being able to use that env in xcode/gradle/etc is really the most important feature here

so it was a no brainer to say no to react-native-dotenv and somehow get things working and I did.

I'm using my vars in JS, Gradle, Objective-C, Java, XML and Info.plist. The only issue I haven't been able to address is that in Circle CI builds Info.plist vars are always empty so I had to address that by manually entering the needed values for particular schemes as user settings and then refer to that var in the Info.plist file, which is not such a big deal but regardless, it would be awesome to have all configs in just one file.

No doubt this module is very powerful and it works but; most of the pain comes from the confusing documentation on Github and npmjs. Can we at least correct that first? Pretty sure there won't be as much of an outcry from the community if the documentaion is not confusing them in the first place.

mvrdrew commented 4 years ago

Hi everyone, I'm going to be out of contact for about a week so apologies in advance for not being able to progress the fork until I'm available again. However, if there are any pull requests you'd like to see merged please feel free to raise them in the meantime. In particular, any documentation changes that @JanithaR has mentioned would be a great starting point. I've also gone through the PRs raised against this repo that I'd like to see merged too, so hopefully when I'm free again next week we'll be in a better position to get a new package published (one way or another!)

pedro commented 4 years ago

sounds good, yeah I haven't been following but if anyone can point me to important PR's to merge here I'll give it a try and merge/publish it - at least to stop the bleeding!

JanithaR commented 4 years ago

It's weekend for me and I'm with my kid and wife fulltime. I'll extend my help first thing Monday.

kelset commented 4 years ago

@pedro how about as step 0 you just migrate this repo to @melodydrewvr (of give him admin rights to the repo & the publishing ones too)?

I'll link this conversation back into the discord.

pedro commented 4 years ago

Definitely, added!

I'll just add a mention of Lugg to the readme, but up to you guys where to take it from here 👌

alexpchin commented 4 years ago

Hi all, do we have an ETA for this move to react-native-community?

leethree commented 4 years ago

@pedro could you publish a new version of this library so we can use while waiting for the migration?

kelset commented 4 years ago

👋 folks - @melodydrewvr was on holiday last week, so it will take a bit longer before this lib will get back on its feet, but a bit of patience will go a long way.

Hi all, do we have an ETA for this move to react-native-community?

No ETA no this for the foreseeable future, if there are updates on that we will keep you updated :)

pedro commented 4 years ago

@leethree oh doh! yes just pushed v0.12.0.

alexpchin commented 4 years ago

What was included in the v0.12.0 release? There are no notes attached... Is is basically a release of the master branch of this repo, i.e. what was previously:

"react-native-config": "github:luggit/react-native-config#master"

Or were any PRs or changes included? Thanks!

pedro commented 4 years ago

Oh yea - it was just a few things pending in master, basically just #349 !

rnnyrk commented 4 years ago

Good to hear that it’s being picked up again! Since react-native-dotenv doesn’t match my requirements.

JanithaR commented 4 years ago

Finally! Guys, the instructions under "Availability in Build settings and Info.plist" works fine for me on my MAC but not on CircleCI. I couldn't spend as much time to figure out why. Basically things were working just fine everywhere except when writing to the InfoPlist file. My vars were always left empty. It could be common to all CI pipelines. Just a heads up.

Reported an issue here

sarmad1995 commented 4 years ago

We will really like this package to be moved to the community, this package has a good potential and functionality which others do not have, and the issues are just pilling up.

tgearig commented 4 years ago

Even with release 0.12, I still have build errors as described in the RN 0.60.6 upgrade thread. None of the suggested workarounds have helped. There are still issues when not using the extra cocoapods script even though #349 said it should not be necessary anymore, but even using them doesn't resolve all the problems. There also appears to be at least one pull request related to fixing RN 0.60.x issues that is still open. This is a blocker for upgrading our projects, and it'd be really helpful if the migration would occur so these can get resolved.

mvrdrew commented 4 years ago

Hi all, apologies for the radio silence on my end. As was previously mentioned I was on holiday for a week, then work decided to go nuts for a while and then, if that wasn't enough, my house decided to start falling apart.

I'm hoping to have a bit of time to look at it this week, but until then what are the most pressing issues everyone's having? Going back through this thread it appears to be mostly documentation inaccuracies and Info.plist failing on CircleCI. I'm afraid I can't test the problems with CI builds, but does it only happen on CircleCI or is it affecting other CI services?

JanithaR commented 4 years ago

I don't think the documentation is inaccurate anymore. Well, it would be nice if the docs mentioned to remove GeneratedInfoPlist.h from Xcode settings. That was required to be done on a previous version. Other than that I think newcomers and inexperienced are in safe hands.

Better if you could fix the 0.60+ issues first. Those are huge deal breakers.

Regards, Janitha

On Mon, Nov 25, 2019, 20:11 Drew Miller notifications@github.com wrote:

Hi all, apologies for the radio silence on my end. As was previously mentioned I was on holiday for a week, then work decided to go nuts for a while and then, if that wasn't enough, my house decided to start falling apart.

I'm hoping to have a bit of time to look at it this week, but until then what are the most pressing issues everyone's having? Going back through this thread it appears to be mostly documentation inaccuracies and Info.plist failing on CircleCI. I'm afraid I can't test the problems with CI builds, but does it only happen on CircleCI or is it affecting other CI services?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/luggit/react-native-config/issues/382?email_source=notifications&email_token=AA3O4AHYXGHK2EXXLXZEM7LQVPPY5A5CNFSM4INX3H52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFCTXJQ#issuecomment-558185382, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA3O4AA7FYYMAZO6YN2OJNTQVPPY5ANCNFSM4INX3H5Q .

export-mike commented 4 years ago

@melodydrewvr yeah I'm getting the issues with circleci where my Info.plist keys $(NAME_OF_ENV) are not being replaced. it does work perfectly fine locally.

strange.

export-mike commented 4 years ago

it appears the tmp.xcconfig is being populated just fine but xcode isn't reading it and passing it over to the plist file

JanithaR commented 4 years ago

Related https://github.com/luggit/react-native-config/issues/391#issuecomment-562843897

atulmy commented 4 years ago

@kelset, can we expect to see this package move to https://github.com/react-native-community soon? @pedro has already given a go ahead to do so in this comment.

May the force be strong with React Native!

Screenshot 2020-01-12 at 1 29 52 AM
kelset commented 4 years ago

no updates on my side, there was some pushback when I asked internally 😓 I'll try to ask again

safaiyeh commented 4 years ago

Hi @kelset someone brought this up to me. Not sure the reasoning for the push back, but I wouldn't mind helping maintain the repo when in community.

JanithaR commented 4 years ago

That would be me. Thanks in advance on behalf of everyone using react-native-config and godspeed. :D

kelset commented 4 years ago

Hey everyone, I tried to raise this again in the internal Discord but I'm sorry to report that - basically - until this conversation (https://github.com/react-native-community/discussions-and-proposals/issues/176) has reached a final say, there should be no expectation of this repo being moved in the RNCommunity.

What I would recommend for the time being is that the repo & npm rights are given directly to one of the new maintainers.

compojoom commented 4 years ago

Who are the new maintainers now? @mvrdrew - I don't see a fork under your account?

mvrdrew commented 4 years ago

I think a lot of interest in updating maintainers died out when a new npm release with the auto-linking included, as that was the biggest blocker a lot of people seemed to have.

I did make a fork under a different account with the intention of getting it into shape for RNC, but after some discussions with @kelset about whether it'd be accepted I lost a bit of momentum. The fork is here: https://github.com/x-react-native/env-config

compojoom commented 4 years ago

@mvrdrew So what are we going to do? I haven't used the library in an year and I'm looking at it for another project. There are 37 pull requests - which doesn't really give me the confidence that it works.

With react-native-community refusing to accept such packages it leaves us at a very unfortunate place.

We either have to create a b-league as @kelset put it in the discussion on the react-native-community issues or just fork ourselves. I'm against forking myself and adding the pull-requests I'm interested in as this create a disconnected ecosystem. Nobody knows what is current and what not.

kelset commented 4 years ago

just to clarify folks - I don't think that forking is the solution, but migrating this repo to another user so that it has an active maintainer with all the permissions (both github and npm).

I don't know if @pedro has the correct rights to do so since IIRC admin rights are needed.

luancurti commented 4 years ago

@erickreutz @pedro Can you help us to migrate to another user that maintain this repo? or give the role (access to commit and publish this package) for someone to volunteer to maintain this repo (I'm one).

Who else volunteers? like this comment to @erickreutz and @pedro (or any repo owner) so they know who the volunteers are

pedro commented 4 years ago

for sure! it's unfortunate that the move to react-native-community got stuck, but happy to give you access so we can keep things going! :+1: just did it, let me know if anything.

What's your npm handle? I can give you permissions to release it too.

luancurti commented 4 years ago

for sure! it's unfortunate that the move to react-native-community got stuck, but happy to give you access so we can keep things going! 👍 just did it, let me know if anything.

What's your npm handle? I can give you permissions to release it too.

@pedro thanks! my npm https://www.npmjs.com/~luancurti and npm email luancurti@gmail.com

pedro commented 4 years ago

You're the man! Really amazing how you already got to all that stuff!

I'm getting this error trying to add you to the project, any ideas?

$ npm owner add luancurti
npm ERR! code E405
npm ERR! 405 Method Not Allowed - PUT https://registry.npmjs.org/react-native-config/-rev/51-6193bee3061b0569f33fb50db3d00c10

$ npm -v
6.14.2

Can't seem to do it via the web either 🤔