search

lugnitdgp / ReviewBook

0 stars 12 forks source link

when clicked on submit button of editing form of review nothing happened ...fixed the bug #28

Closed deadlycoder07 closed 4 years ago

deadlycoder07 commented 4 years ago

fixed the bug

chiragagarwal54 commented 4 years ago

There are issues with your pull request.

  1. Your pull request is not as per the guidelines stated in CONTRIBUTING.md file. Do have a look into it.
  2. The button was working, there was just a need to redirect after clicking the button. Although you have solved that, but your pull request contains some unnecessary changes also. There was no need to copy the get_queryset function.

When you put up a pull request, just make sure that you are very specific to the issue you are looking to solve with that pull request. Please put up another pull request by considering the above.

deadlycoder07 commented 4 years ago

okay will take that into consideration

deadlycoder07 commented 4 years ago

changed the code as per your instructions