godscreator
commented
5 years ago Ok
On Thu, Mar 14, 2019, 12:18 AM Ankan Poddar <notifications@github.com wrote:
@ankan17 requested changes on this pull request.
Thanks a lot for the PR. Looks just about right. However, there are a few minor modifications required.
In core/templates/core/balance.html https://github.com/lugnitdgp/freemex/pull/25#discussion_r265278624:
+ +
Balance
Cash in your hand: ${{ player.cash }}
Stock name Status Qty. Just make it as "Quantity"
In core/templates/core/includes/navbar.html https://github.com/lugnitdgp/freemex/pull/25#discussion_r265279242:
@@ -23,6 +23,9 @@
I think it's better to name this feature (and hence, the tab) as "Transactions". Please change balance to transactions at all places.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lugnitdgp/freemex/pull/25#pullrequestreview-214144907, or mute the thread https://github.com/notifications/unsubscribe-auth/AYLQWNK2fAKXOpIwNHSdYfIaaRKmafWmks5vWUgBgaJpZM4bpQQj .
made changes as requested
Made changes as requested
On Thu, Mar 14, 2019, 7:43 AM Nitesh kumar <shubhamdragonsin@gmail.com wrote:
Ok
On Thu, Mar 14, 2019, 12:18 AM Ankan Poddar <notifications@github.com wrote:
@ankan17 requested changes on this pull request.
Thanks a lot for the PR. Looks just about right. However, there are a few minor modifications required.
In core/templates/core/balance.html https://github.com/lugnitdgp/freemex/pull/25#discussion_r265278624:
+ +
Balance
Cash in your hand: ${{ player.cash }}
Stock name Status Qty. Just make it as "Quantity"
In core/templates/core/includes/navbar.html https://github.com/lugnitdgp/freemex/pull/25#discussion_r265279242:
@@ -23,6 +23,9 @@
I think it's better to name this feature (and hence, the tab) as "Transactions". Please change balance to transactions at all places.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lugnitdgp/freemex/pull/25#pullrequestreview-214144907, or mute the thread https://github.com/notifications/unsubscribe-auth/AYLQWNK2fAKXOpIwNHSdYfIaaRKmafWmks5vWUgBgaJpZM4bpQQj .
Thanks for merging 😁
On Fri, Mar 15, 2019, 10:02 PM Ankan Poddar <notifications@github.com wrote:
@ankan17 approved this pull request.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lugnitdgp/freemex/pull/25#pullrequestreview-215133430, or mute the thread https://github.com/notifications/unsubscribe-auth/AYLQWB-PJfh0D8pl2fZzIz-xH1ugSmM0ks5vW8sJgaJpZM4bpQQj .
Fixes issue #23 - Created a transaction recording page "balance" with profit and loss column
branch name is "balance"
(p.s This is my first time contributing . )