search

luheng / deep_srl

Code and pre-trained model for: Deep Semantic Role Labeling: What Works and What's Next
Apache License 2.0
330 stars 77 forks source link

hardcoded path :( #1

Closed huihuifan closed 6 years ago

huihuifan commented 6 years ago

I don't think you should hardcode the path (for ex: in run_end2end.sh). It becomes quite confusing to use this code in different places. In many instances, people probably either already have this set in bashrc or otherwise have a path configuration, and you are hard setting it, which can create issues.

luheng commented 6 years ago

Thank you for pointing this out. I wrote these scripts mainly for showing users how to run the python code. Sorry for the confusion. Will clarify.