luhenry / netlib

An high-performance, hardware-accelerated implementation of Netlib in Java
Other
64 stars 12 forks source link

Add Automatic-Modules-Name #13

Closed uhoefel closed 2 years ago

uhoefel commented 2 years ago

Currently, the package names are still considered unstable in an JPMS sense. Adding the package name to the MANIFEST should fix this. I ran the tests and test-compile in a local Docker container and everything seemed to work. I think this should be backwards compatible with non-JPMS uses as well, I think this is just an additional entry in the MANIFEST.

Note that this does not solve requiring arpack.combined.all for example for intW, so one still has an unstable requires clause in the module-info.java. Maybe it would make sense to wrap the helper classes from the old arpack.combined.all to avoid users having to explciitly requiring it?