luigi311 / JellyPlex-Watched

Sync watched between jellyfin and plex locally
GNU General Public License v3.0
394 stars 22 forks source link

Jellyfin/Emby: Check partial sync support #185

Closed luigi311 closed 2 months ago

luigi311 commented 2 months ago
luigi311 commented 2 months ago

@awakenedhaggis can you take a look at this. I cherrypicked your commit but looks like it lost you as the author. Can you make a PR with a commit similar to this that way it marks you as the author. I rebased it on main and used packaging version to handle the version checks instead of manually checking it.

luigi311 commented 2 months ago

looks like i had some typos in the original implementation so it should be good to go now. Can you clean with whitespace on your commit, if not ill clean it up afterwards since im going to clean up a lot of the formatting issues

awakenedhaggis commented 2 months ago

Hi @luigi311 ! Is there any specific style guides you want to follow? I can set up a config for black or your preferred formatter

luigi311 commented 2 months ago

i want to switch over to using ruff but ive just been using the default black options for now.

awakenedhaggis commented 2 months ago

On my end looks like all the author lines were preserved! Might be better to keep this PR so it credits your lines properly

I think unless theres anything glaring here there can be a separate PR for global formatting changes, to keep the change history a bit cleaner if anything