luigi311 / JellyPlex-Watched

Sync watched between jellyfin and plex locally
GNU General Public License v3.0
394 stars 22 forks source link

[BUG] Partially watched videos are not matching between servers correctly #192

Open devanteweary opened 2 weeks ago

devanteweary commented 2 weeks ago

Describe the bug I recently noticed that jellyplex-watched is marking the same entries every loop.

I happened to be looking at some logs and saw that JP-Watched is doing the exact same marks every loop.
This has been going on since at least June 3rd, 2024 if not longer.

HEre's a sample of the syslog - note I filtered this to just one entry just to show that it's repeating, but it's marking a bunch of stuff the same way every loop:

image

Here's a partial console log of the latest loop:

image

I checked the appdata folder and there are no logs, or any other files.

Everything looks "successful" as there are no errors.
It's just... keeps marking the same thing for everyone.

By the way, it is accurate because if I go and finish a show that it marked, the next loop it won't mark it anymore.

I bring this entire issue/bug up because I don't remember it doing this a while ago. In fact I distinctly remember it going through the "Generating watched for in library messages, then nothing once it had already marked stuff for people.

Anyway, thought I'd let you know!

Thank you!

luigi311 commented 1 week ago

I am seeing the same thing on my side with partially watched only too so i think its an issue with the function that checks for matches between servers not handling the partials correctly.

luigi311 commented 1 week ago

@devanteweary Do you know if they are all shows where there is just a single episode that is partially watched? I noticed if i partially watch an episode and its the only episode "seen" so far in that show that jellyfin will still report your watch progress for that show as 0.

devanteweary commented 1 week ago

@devanteweary Do you know if they are all shows where there is just a single episode that is partially watched? I noticed if i partially watch an episode and its the only episode "seen" so far in that show that jellyfin will still report your watch progress for that show as 0.

I checked the latest console logs and see that that a few series are multiple episodes (well, two).

image

luigi311 commented 1 week ago

Yea i think the jellyfin apis only increase the played percentage statistic for a show for fully watched episodes so if there isnt a single fully watched episode in that entire show i never pick it up on the jellyfin side while the plex side does so thats why it keeps getting marked. I would need to change how i grab watched episodes in general to avoid this or have the jellyfin api change to include partially watched episodes in its user data statistics.

devanteweary commented 1 week ago

Yea i think the jellyfin apis only increase the played percentage statistic for a show for fully watched episodes so if there isnt a single fully watched episode in that entire show i never pick it up on the jellyfin side while the plex side does so thats why it keeps getting marked. I would need to change how i grab watched episodes in general to avoid this or have the jellyfin api change to include partially watched episodes in its user data statistics.

If I'm right about the date, that's when version 10.9.4 came out.

https://forum.jellyfin.org/f-project-announcements