luigi311 / JellyPlex-Watched

Sync watched between jellyfin and plex locally
GNU General Public License v3.0
394 stars 22 forks source link

Draft: Usability/logging #69

Closed Nicba1010 closed 2 months ago

Nicba1010 commented 1 year ago

Replaces the stock logging function with the loguru module. A work-in-progress.

Based on the updated CI branch, will rebase after merge.

luigi311 commented 1 year ago

Looks like the action fails when pushing from a PR that someone else makes. I tried changing it to actor and repository instead to see if that works so try a rebase if you can. If not i can probably just disable the push on PR

Nicba1010 commented 1 year ago

@luigi311 could this be it? image

luigi311 commented 1 year ago

yeah thats probably it. Ill go ahead and put a enable clause on the ghcr tag for none pr

Nicba1010 commented 1 year ago

And if you can fix the build step conditional so that it builds if it's a PR OR if the docker_meta outcome is skipped.

luigi311 commented 1 year ago

ok give it a try. I added in that enable check for PR for the ghcr and i also swapped the condition check for the build/build push so it checks for tags in the meta step to see if theres any repo to push to at all.

Nicba1010 commented 1 year ago

@luigi311 thanks :) seems to work

Nicba1010 commented 1 year ago

Anyways, this still isn't complete but I thought of giving multiple logging options.

Does that sound ok? And allow the user to disable them as willing.

luigi311 commented 1 year ago

Its probably best to leave out the all runs from beginning of container creation since hopefully this container never crashes and depending on how often they have it loop and how verbose it is, it will spit out a ton of data.

Nicba1010 commented 1 year ago

So just keep the latest run then? Maybe disable per-run logs by default but let the user choose (and auto-compress them).

luigi311 commented 1 year ago

sure that can be an option