CarlKCarlK
commented
2 years ago Luke,
Excellent suggestions and questions.
- Is this class expected to only be used in the context of your test? Yes and no.
I think of it as a prototype class that will likely evole in the future to work with the rest of the system (while still being easy to unit test).
So, we should make it nice, but shouldn't make it too nice because it will likely change and evolve.
- Carl
From: Luke Bordonaro @.> Sent: Sunday, December 05, 2021 7:34 PM To: luillo1/RaceResults @.> Cc: Carl Kadie @.>; Author @.> Subject: Re: [luillo1/RaceResults] Update *.csproj's, add tests to solution, improve style of tests (PR #37)
@MutatedGamer commented on this pull request.
+namespace RaceResults.MemberMatch
+{
-
public class Members
-
{
-
private Dictionary<string, HashSet
> nameToMemberSet; -
private HashSet
citySet; -
public Members(string filename)
-
{
-
this.nameToMemberSet = new Dictionary<string, HashSet
>(); -
this.citySet = new HashSet
(); -
foreach (string line in File.ReadLines(filename).Skip(1))
-
{
-
var fields = line.Split('\t');
-
Trace.Assert(fields.Length == 4, "Expect four fields in the 'sample_member.tsv' file");
Is this class expected to only be used in the context of your test?
- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fluillo1%2FRaceResults%2Fpull%2F37%23pullrequestreview-823508154&data=04%7C01%7C%7C1cb7a11c463444de9dd808d9b8693372%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637743584234245285%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=oAv5K78mY1Kwdzdn8gGBfMjPP8FtjlxEedcwcEzu9X0%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABR65P25RNT5PNLCKYXJ2T3UPQVJLANCNFSM5JF7R6OQ&data=04%7C01%7C%7C1cb7a11c463444de9dd808d9b8693372%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637743584234245285%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=klmno8lkGQMjYp19ImE3cuwBHs8dMoZY1NDBxnDI4ss%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7C1cb7a11c463444de9dd808d9b8693372%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637743584234250262%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=mCR2lBDLSfR7yQOhkMeOnNjk5fpV5XQV4MPBP1XzEP8%3D&reserved=0 or Androidhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7C%7C1cb7a11c463444de9dd808d9b8693372%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637743584234260223%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=Oc%2BrN5gCYJpWHwgJKs7pDLAIHOh%2FIs0Jo1P8Xol296k%3D&reserved=0.
This should only improve the VS experience and the style of test membermatch tests.