Issue regarding the fallback alternative in JSONValue.toJSONString

[GoogleCodeExporter]

Hi,

Right now the fallback of JSONValue.toJSONString is:

         return value.toString();

Wouldn't something like the following be better, since the current
implementation can render invalid JSON with a bad toString?

         return "\"" + escape(value.toString() + "\"";

Original issue reported on code.google.com by anders.r...@gmail.com on 30 Jun 2010 at 1:16

• Merged into: #26

[GoogleCodeExporter]

Looks sane to me too. Blindly returning result of value.toString() is a bug 
IMO. Any way to produce valid JSON is much better than this. Either escape it 
like suggested or return null or "undefined" or whatever.

Original comment by fano...@gmail.com on 14 Jul 2010 at 12:03

[GoogleCodeExporter]

Original comment by fangyid...@gmail.com on 14 Jul 2010 at 1:10

• Changed state: Accepted
• Added labels: Type-Enhancement
• Removed labels: Type-Defect

[GoogleCodeExporter]

Issue 18 has been merged into this issue.

Original comment by fangyid...@gmail.com on 14 Jul 2010 at 1:15

[GoogleCodeExporter]

Oops, i didn't notice this one, i'm sorry, issue #33 is a duplicate :_(
Anyway, the problem seems to affect writeJSONString as well.
Here's a small patch that seems to work for me...

bye.

Original comment by sanita.c...@gmail.com on 4 Aug 2010 at 9:11

Attachments:

• jsonvalue.patch

[GoogleCodeExporter]

Issue 33 has been merged into this issue.

Original comment by fangyid...@gmail.com on 5 Aug 2010 at 12:15

[GoogleCodeExporter]

hello. I just wanted to ask, if there will be a next version of the json-simple 
library with this enhancement in the near future. 

Original comment by berndhub...@googlemail.com on 21 Feb 2011 at 10:44

[GoogleCodeExporter]

Not sure what does "near future" mean to you, but I do have a plan making some 
improvement of json-simple this year. Will let your guys know once I have any 
update.

Thanks,
Yidong. 

Original comment by fangyid...@gmail.com on 22 Feb 2011 at 4:49