search

luin / readability

📚 Turn any web page into a clean view
2.49k stars 312 forks source link

Add candidateFilters option #107

Open hankliu62 opened 6 years ago

hankliu62 commented 6 years ago

@luin @haroldtreen Please help review, and give some suggestions, thanks.

haroldtreen commented 6 years ago

This looks like an interesting option @hankliu62 👍 . What do you think about calling it candidateFilters? Filters just accept a single candidate, so it makes a bit more sense to me.

Curious if @luin has thoughts because I know less about the history of this module 😅 .

hankliu62 commented 6 years ago

@haroldtreen, thanks for all your help! I've updated PR according to your instructions. Let me know if I've missed something.

haroldtreen commented 6 years ago

Thanks for the updates @hankliu62 !

Only last thing I would consider is bumping the version in package.json to 3.1.0 to indicate a new feature has been added. Also note the new feature in CHANGELOG.md.