search

luin / readability

📚 Turn any web page into a clean view
2.49k stars 312 forks source link

Why is lightbox in unlikelyCandidatesRe? #93

Closed wong2 closed 7 years ago

wong2 commented 7 years ago

it's very likely to be an image right?

haroldtreen commented 7 years ago

I didn't write the original regex, but I'm assuming it helps remove galleries?

Have you found some sites that are broken from this? I haven't come across any issues with it.

Hopefully that answers, but feel free to reopen if you have an argument for changing it.

wong2 commented 7 years ago

@haroldtreen here is a bad case: https://zhuanlan.zhihu.com/p/28248770 the images are removed by node-readability due to the lightbox classname

haroldtreen commented 7 years ago

Thanks for that example!

In that case, I'm open to removing it.