luinardi / hypermapper

Black-box Optimizer based on Bayesian Optimization
MIT License
152 stars 26 forks source link

Resuming optimization breaks with non-string feasible values #96

Open UnsignedByte opened 3 months ago

UnsignedByte commented 3 months ago

https://github.com/luinardi/hypermapper/blob/3dfa8a7010792546e2d688b6113569b0cf36958e/hypermapper/space.py#L1445-L1453

These lines check if the values read from the resume CSV match the values expected, but fails to consider the fact that reading from the csv automatically turns every value into a string, which breaks the feasible predictor for non-string feasible values. Instead, the line should be elem == str(self.feasible_output_true).