luis-almeida / unveil

A very lightweight jQuery plugin to lazy load images
4.16k stars 676 forks source link

jQuery 1.8+ : Update doc for the callback example #126

Open crtlf opened 7 years ago

crtlf commented 7 years ago

When trying the callback example :

$("img").unveil(200, function() {
  $(this).load(function() {
    this.style.opacity = 1;
  });
});

... I just had the following error : Uncaught TypeError: a.indexOf is not a function

From the jQuery blog :

.load, .unload, and .error, deprecated since jQuery 1.8, are no more. Use .on() to register listeners.

So, if you just came across this error, you'll have to change the load function call to :

$(this).on('load', function() { ... });

It could be nice to update the documentation :) More info here : http://stackoverflow.com/questions/37738732/jquery-3-0-url-indexof-error

tzws commented 7 years ago

Hi, I think the js should be:

$("img").unveil(200, function() {
    $(this).load(function() {
        this.style.opacity = 1;
    })
});