Add FVM config - Githubissues

luis901101 / fhir_questionnaire

A library to render FHIR Questionnaires and generate a QuestionnaireResponse

BSD 2-Clause "Simplified" License

4 stars 4 forks source link

Add FVM config #1

Closed easazade closed 5 months ago

easazade commented 5 months ago

Adding fvm config for flutter version management to set the flutter version used for development. this will help contributors to know and use the same flutter version when developing and running pub commands

easazade commented 5 months ago

@luis901101 Also fixed an overflow error that was showing in example app

luis901101 commented 5 months ago

Hi @easazade thanks for your contribution

luis901101 commented 5 months ago

Adding fvm config for flutter version management to set the flutter version used for development. this will help contributors to know and use the same flutter version when developing and running pub commands

Regarding the fvm config, I'm not agree with adding this to the project repo, I mean anyone should be able to collaborate using whatever tools or setup they decide, also for the required version the pubspec.yaml is the one to define that, like:

environment:
  sdk: '>=3.0.0 <4.0.0'
  flutter: '>=3.3.0'

Maybe the minimum flutter version could be increased, but as far as I remember the package didn't require a greater version so for compatibility purposes I leave it as 3.3.0.

easazade commented 5 months ago

@luis901101

just a question not regarding this PR: in library code there is QuestionnaireUtils class that has some sample questionnaires that are only used in example app. should it be there instead?

luis901101 commented 5 months ago

@luis901101

just a question not regarding this PR: in library code there is QuestionnaireUtils class that has some sample questionnaires that are only used in example app. should it be there instead?

Yeah, it should not be in the QuestionnaireUtils it makes more sense to be a utils class only for the example project, if you want you can change it and commit.