search

luis901101 / fhir_questionnaire

A library to render FHIR Questionnaires and generate a QuestionnaireResponse
BSD 2-Clause "Simplified" License
4 stars 4 forks source link

Questionnaire response item mapper #7

Closed easazade closed 3 months ago

easazade commented 4 months ago

This will add the possibility to modify a QuestionnaireResponseItem after it was generated within QuestionnaireController.

This could be a useful addition. There could be use cases which it is required to modify a QuestionnaireResponseItem object after it has been created. eg: Adding additional extensions to it.

luis901101 commented 3 months ago

LGTM but please fix the conflicts generated by the recent commits so the merge can be done.

luis901101 commented 3 months ago

Regarding this PR 7 and also 8, and 9, are all good ideas, I was eager to merge it but there were conflicts... I'm a bit short of available time so I take advantage of this chance I had now and made some of these changes you proposed... Basically I made QuestionnaireController more extendable by dividing the functions to build the items views and responses into individual functions so it can be override, and also added the same functions as params so it's not mandatory to extend QuestionnaireController to be able to override the items functions.

easazade commented 3 months ago

Regarding this PR 7 and also 8, and 9, are all good ideas, I was eager to merge it but there were conflicts... I'm a bit short of available time so I take advantage of this chance I had now and made some of these changes you proposed... Basically I made QuestionnaireController more extendable by dividing the functions to build the items views and responses into individual functions so it can be override, and also added the same functions as params so it's not mandatory to extend QuestionnaireController to be able to override the items functions.

Thanks for the response and looking into the PRs. Should I close PRs #7 , #8 & #9 if you have already applied similar changes?

luis901101 commented 3 months ago

Regarding this PR 7 and also 8, and 9, are all good ideas, I was eager to merge it but there were conflicts... I'm a bit short of available time so I take advantage of this chance I had now and made some of these changes you proposed... Basically I made QuestionnaireController more extendable by dividing the functions to build the items views and responses into individual functions so it can be override, and also added the same functions as params so it's not mandatory to extend QuestionnaireController to be able to override the items functions.

Thanks for the response and looking into the PRs. Should I close PRs #7 , #8 & #9 if you have already applied similar changes?

Yeah I think so,