luisDanielRoviraContreras / flutter_iconsax

iconsax for flutter package
GNU General Public License v3.0
30 stars 18 forks source link

A lot of icons do not work/render properly #1

Open 31Carlton7 opened 3 years ago

31Carlton7 commented 3 years ago

As I was testing the package, I noticed that quite a few of the icons do not render properly or even at all sometimes.

Code Snippet: Screen Shot 2021-08-20 at 2 35 26 PM

App: IMG_6852

Here's an example of the icons not rendering properly

Figma / What it's supposed to look like: Screen Shot 2021-08-20 at 2 39 52 PM

App: IMG_6853

I think there's an issue with the icon font.

LearningLeopard commented 3 years ago

Thank you for such amazing plugin to get awesome icons. Facing this same issue. Icons aren't even rendering for me. Please solve this issue.

31Carlton7 commented 3 years ago

@luisDanielRoviraContreras Could you regenerate the font file and see if it helps?

LearningLeopard commented 3 years ago

I'm a little new to flutter plugins. How do I regenerate the file? Thanks for your help.

On Wed, Aug 25, 2021, 11:46 PM Carlton Aikins @.***> wrote:

@luisDanielRoviraContreras https://github.com/luisDanielRoviraContreras Could you regenerate the font file and see if it helps?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/luisDanielRoviraContreras/flutter_iconsax/issues/1#issuecomment-905765053, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARRPXLRCQZ4L3VIM5EVDNJ3T6UXQXANCNFSM5CQ2T72Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

-- The information contained in this electronic communication is intended solely for the individual(s) or entity to which it is addressed. It may contain proprietary, confidential and/or legally privileged information. Any review, retransmission, dissemination, printing, copying or other use of, or taking any action in reliance on the contents of this information by person(s) or entities other than the intended recipient is strictly prohibited and may be unlawful. If you have received this communication in error, please notify us by responding to this email or telephone and immediately and permanently delete all copies of this message and any attachments from your system(s). The contents of this message do not necessarily represent the views or policies of BITS Pilani.

31Carlton7 commented 3 years ago

I would navigate to their website and download their svgs. Then I would probably go to icomoon and import them, then try to generate a new icon font. If you do this successfully, then you should get a .ttf file which you can open up and view all the icons. If it looks like every last icon is there without any kind of problems or issues then you should come back here and submit a Pull Request, and hopefully it gets merged. If it's too confusing, I'll find time to do this myself and hopefully we can get some good icons 💯

Biftor commented 3 years ago

In order to find and suitable icon in easier way, i've just made very simple web application to show the icons. You can see which icons have render problem to maybe provide fixes in future.

IconSax Preview

this is very simple application i couldn't find more free time to improve it, it is what it is and solve my complexity project github repo feel free to PR

also i couldn't find why the icons not render in github page same thing is working on firebase.

esenmx commented 3 years ago

The problem is related to svg parsing. Some svgs have unsupported commands/tags and some of them poorly formatted like referencing the style before the declaration etc.

When you upload the svg to the converter service, because of these flaws, it can't convert properly. I don't know any straightforward accurate solution since it's not within my expertise but it can be solved by editing the svg's manually, which is very cumbersome. Remove any script and non-render tags, move references to bottom and it can be solved.