luisFilipePT / github-covid-finder

A simple application to find open source repos fighting Covid / Corona virus
https://commit-to-fight-covid.netlify.com/
MIT License
12 stars 10 forks source link

Improve pagination #40

Closed urmauur closed 3 years ago

urmauur commented 4 years ago

Hi @luisFilipePT sorry for taking a long time, need to cleanup some errand.

29 solved issue

urmauur commented 4 years ago

@luisFilipePT can you add this pr with hacktoberfest-accepted

luisFilipePT commented 4 years ago

@urmauur can you confirm pagination is working? I tested on the preview deploy and it's not working

urmauur commented 4 years ago

@urmauur can you confirm pagination is working? I tested on the preview deploy and it's not working

seems like its broken, I'm on it now 🙏🏻

urmauur commented 4 years ago

@luisFilipePT can you check in the live version? https://commit-to-fight-covid.netlify.app on my side that broken

urmauur commented 4 years ago

@luisFilipePT updated MR

luisFilipePT commented 4 years ago

@luisFilipePT can you check in the live version? https://commit-to-fight-covid.netlify.app on my side that broken

ok, now the pagination is working but we cannot search on typing due to the rate limit on github, we need to remove this and only search on enter or click on the icon.

urmauur commented 3 years ago

@luisFilipePT sorry for late reply, can you guys check this ?

luisFilipePT commented 3 years ago

@luisFilipePT sorry for late reply, can you guys check this ?

It's still broken on the Preview, just keep typing and you should see it break, it cannot search on typing :/

urmauur commented 3 years ago

@luisFilipePT sorry my bad hehhe, hope this is fix all function, seems like somebody change search 🙏🏻

urmauur commented 3 years ago

Hi @luisFilipePT can you check this PR ?