luisTJ / ghostplusplus

Automatically exported from code.google.com/p/ghostplusplus
Other
0 stars 0 forks source link

Command delban gives same response no matter of the result #98

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. use command delban with player that never was banned

What is the expected output? What do you see instead?
expected: message - player is not banned or can not be found
actual: message - requested player was unbanned

What version of the product are you using? On what operating system?
16.2

Please provide any additional information below.

Original issue reported on code.google.com by sheeptag...@gmail.com on 2 Oct 2010 at 3:29

GoogleCodeExporter commented 9 years ago
This is because GHost++ never checks if the person was banned - it just deletes 
the entry if it exists, if not, it's not a problem. Checking if the person IS 
banned with just create unnecessary overhead.

If you really want to know if someone is banned, use !checkban or see inside 
the database itself (phpmyadmin, sqlite database manager etc.).

Original comment by dinamo.f...@gmail.com on 5 Nov 2010 at 5:33

GoogleCodeExporter commented 9 years ago
Databases usualy return number of affected rows after query like delete. 
Doesn't sqlite support this feature? It is really confusing now. You never know 
if you wrote player's nick correctly since unban gives no result.

Original comment by sheeptag...@gmail.com on 11 Nov 2010 at 10:36

GoogleCodeExporter commented 9 years ago
You should check the SQLite documentation:

http://www.sqlite.org/c3ref/changes.html

Original comment by dinamo.f...@gmail.com on 12 Nov 2010 at 7:54