luisarizmendi / ocp-libvirt-ipi-role

Ansible Role to deploy OpenShift 4 on a CentOS 7 or Fedora KVM using libvirt IPI
31 stars 14 forks source link

Stop checking 'master' out, checkout the matching commit. #13

Closed ElCoyote27 closed 3 years ago

ElCoyote27 commented 3 years ago

This is related to this: https://github.com/openshift/installer/issues/4332 Some changes introduced in master before 4.5.16 became incompatible with previous versions. Since the role was checking out 'master' instead of the proper commit, it left us unable to deploy 4.5 until the matching changes merged into the installer (4.5.18). For me, it meant that 4.5 deploys were broken for almost 10 days. After some research, guidance came from the developers: checkout the proper commit version for the version you're trying to install. I finally managed to fix it in my tree tonight (using the oc command to spit out the proper commit URL). Please let me know what you think @luisarizmendi @kenmoini Thanks, Vincent