luisbocanegra / kde-material-you-colors

Automatic color scheme generator from your wallpaper for KDE Plasma powered by Material You
https://store.kde.org/p/2136963
GNU General Public License v3.0
412 stars 6 forks source link

Default text color is greyish and some colors are too intense #122

Closed luisbocanegra closed 1 year ago

luisbocanegra commented 1 year ago

Describe the bug pywal is kinda messed up

default text color is greyish and some colors are too intense (not sure if that is intentional)

Screenshots image

Originally posted by @ShatteredSkies in https://github.com/luisbocanegra/kde-material-you-colors/issues/118#issuecomment-1345235713

luisbocanegra commented 1 year ago

I did some changes in #119 that include:

This is how it looks here, note that i have the option Konsole > Profile edit > Appearance > Draw intense colors in bold font enabled, probably didn't help that I didn't try with a lot of wallpapers and use opacity of 90% which of course looks worse on screenshots...

Screenshot_20221210_050646

It seemed logical to me that bold text should stand up more, but normal text is too dark now? of course can be improved, open to suggestions.

Originally posted by @luisbocanegra in https://github.com/luisbocanegra/kde-material-you-colors/issues/118#issuecomment-1345244176

luisbocanegra commented 1 year ago

I think it looks better now? current: Screenshot_20221214_094633

on #119

Screenshot_20221214_095300

main: Screenshot_20221214_095038

luisbocanegra commented 1 year ago

Light version, I think it looks good enough, though it depends if the wallpaper has sufficient colors to work with

current: Screenshot_20221214_182115

on #119 Screenshot_20221214_182329

main: Screenshot_20221214_182401

i

luisbocanegra commented 1 year ago

Added to https://github.com/luisbocanegra/kde-material-you-colors/releases/tag/v1.5.0

ShatteredSkies commented 1 year ago

I think it looks better now?

yeah, it does. however, the greyish text still looks weird, especially for something like neofetch image

luisbocanegra commented 1 year ago

How about this? Screenshot_20221215_113535

luisbocanegra commented 1 year ago

Please try the https://github.com/luisbocanegra/kde-material-you-colors/tree/color-scheme-improvements branch (with light themes too, though I think these already looked good enough?)

ShatteredSkies commented 1 year ago

Please try the https://github.com/luisbocanegra/kde-material-you-colors/tree/color-scheme-improvements branch (with light themes too, though I think these already looked good enough?)

just tried, I think the color should be more tinted and a bit brighter, probably matching the titlebar color?

luisbocanegra commented 1 year ago

Hmm, it could be brighter and kind of shifted to the secondary color, but not too much so it would be distinguishable from the other seven (actual) colors

probably matching the titlebar color?

The text? Have to verify but I think that one is actually darker

ShatteredSkies commented 1 year ago

Hmm, it could be brighter and kind of shifted to the secondary color, but not too much so it would be distinguishable from the other seven (actual) colors

yeah, that would be nice.

probably matching the titlebar color?

The text? Have to verify but I think that one is actually darker

huh, it actually looked just a bit darker than the titlebar text on my end. could be because of the font?

luisbocanegra commented 1 year ago

Hmm, it could be brighter and kind of shifted to the secondary color, but not too much so it would be distinguishable from the other seven (actual) colors

yeah, that would be nice.

probably matching the titlebar color?

The text? Have to verify but I think that one is actually darker

huh, it actually looked just a bit darker than the titlebar text on my end. could be because of the font?

Hmm, probably, or the transparency, I'm using 100 opaque rn

luisbocanegra commented 1 year ago

Hmm, it could be brighter and kind of shifted to the secondary color, but not too much so it would be distinguishable from the other seven (actual) colors

yeah, that would be nice.

You can try again now (force pushed btw)

ShatteredSkies commented 1 year ago

Hmm, it could be brighter and kind of shifted to the secondary color, but not too much so it would be distinguishable from the other seven (actual) colors

yeah, that would be nice.

You can try again now (force pushed btw)

looking nice with the tinted colors for the few wallpapers I tested.