search

luisbocanegra / kde-material-you-colors

Automatic color scheme generator from your wallpaper for KDE Plasma powered by Material You
https://store.kde.org/p/2136963
GNU General Public License v3.0
378 stars 6 forks source link

Idea: Porting colors generation back to JavaScript implementation #172

Closed luisbocanegra closed 7 months ago

luisbocanegra commented 9 months ago

Is your feature request related to a problem? Please describe. Is not really a problem but might be easier to integrate the original JavaScript version of material-color-utilities than trying to update the python version and maybe switch back to it after it hopefully gets updated and merged.

Why?

Doing so could help issue https://github.com/luisbocanegra/kde-material-you-colors/issues/126 and also get support for the other scheme variants (mono, neutral, expressive...). Both of which I was trying to add in saturation-and-brightness and color-schemes branches but in python.

Describe the solution you'd like The idea is to drop material-color-utilities-python and make a helper JavaScript cli that receives the pixels (to keep the image processing in python), custom colors and other things and returns the material colors, similar to the C# version that I used in version v0.8.0 and earlier

Downsides Will need to ship the cli project (with @material/material-color-utilities) inside data and obviously depend on nodejs external dependency to be installed.

luisbocanegra commented 9 months ago

Comparison of previous (top) vs port to original TypeScript implementation (bottom) comp

luisbocanegra commented 9 months ago

Scheme variants and chroma control also have been added

comp-chroma

luisbocanegra commented 7 months ago

Well, maybe not. Just found about https://github.com/T-Dynamos/materialyoucolor-python, which is up to date with material-foundation/material-color-utilities/ so will look into using that instead.