luisbocanegra / kde-material-you-colors

Automatic color scheme generator from your wallpaper for KDE Plasma powered by Material You
https://store.kde.org/p/2136963
GNU General Public License v3.0
367 stars 6 forks source link

Unreadable text in some places #71

Closed mikroffarad closed 2 years ago

mikroffarad commented 2 years ago

When I set up perceptible color to maximum (dark_blend_multiplier = 4.0), text on buttons is almost unreadable: Screenshot_20220821_033322~2.png Screenshot_20220821_033612~2.png It's easy to fix it by manually changing text color of buttons in color-scheme file. However, it's inconvenient to do that on every wallpaper change.

Another case is when dark mode is enabled, there's some places where in the bright background bright text color remains

Here's some examples:

I tried to change ForegroundNormal's value (133th line of MaterialYouDark.colors file) to #000000. Text color changes to black, but there's one problem — black text color is also on dark background: Screenshot_20220821_043217~2.png

Is it possible to correct this? I made a little research and realized, that probably there's no rule for ForegroundNormal on bright background. So, is it feature of KDE Plasma's architecture?

Or maybe I configured something wrong?

luisbocanegra commented 2 years ago

When I set up perceptible color to maximum (dark_blend_multiplier = 4.0), text on buttons is almost unreadable:

Another case is when dark mode is enabled, there's some places where in the bright background bright text color remains

  • Dolphin: [image]

I tried to change ForegroundNormal's value (133th line of MaterialYouDark.colors file) to #000000. Text color changes to black, but there's one problem — black text color is also on dark background:

Is it possible to correct this? I made a little research and realized, that probably there's no rule for ForegroundNormal on bright background. So, is it feature of KDE Plasma's architecture?

mikroffarad commented 2 years ago
* Which theme and KDE version are you using?

Sorry for answering after such a long time. Also, sorry I forgot to clarify what my Plasma Style is. I had this problem with the Arc Color Plasma style: 2022-08-22_14-46 But when I changed to default Breath Plasma Style, the result satisfied me completely 👌: 2022-08-22_14-48 I was just reading this comment on Reddit where you wrote what presets you are using: Application Style, Plasma Style, and Window Decoration. You mentioned that there are some changes in Ark Color, but I used vanilla version. Perhaps this had an effect.

If this information is useful to you, here is my configuration: image

mikroffarad commented 2 years ago

Updated to 0.9.1, works flawlessly🙌

mikroffarad commented 2 years ago
  This is how the default plasma style (that follows color scheme) looks:

Screenshot_20220820_195118 Sorry for asking too many questions, I would also like to ask: what is the name of this icon pack?

luisbocanegra commented 2 years ago

I was just reading this comment on Reddit where you wrote what presets you are using: Application Style, Plasma Style, and Window Decoration. You mentioned that there are some changes in Ark Color, but I used vanilla version. Perhaps this had an effect.

Must be it, I probably changed the opacity of that element. Like that theme, and many others aren't made having intense colors in mind, same for icon themes, or even some elements of the Lightly Application Style, and sometimes, vanilla KDE. But we're a community and hopefully we can improve that :).

If this information is useful to you, here is my configuration: image

Thanks.

luisbocanegra commented 2 years ago

Screenshot_20220820_195118 Sorry for asking too many questions, I would also like to ask: what is the name of this icon pack?

Papirus Icons With papirus-colors for tinted folder icons.