search

luiscastilho / dungeoneering

Free and slimmed down virtual tabletop (VTT) that can be used as a combat grid and as a dungeon exploration tool, made for local, in-person tabletop RPG sessions
https://dungeoneering.app
GNU General Public License v3.0
45 stars 3 forks source link

Potentially an issue in ubuntu_install_prereqs.sh? #6

Open mal-w opened 2 years ago

mal-w commented 2 years ago

I'm not really a bash expert but this code was causing issues... It seemed like I was never getting passed the lsb_release checks... Of all things, removing the -e from the set worked... as you can see in the below diff...

-set -euo pipefail
+set -uo pipefail
 IFS=$'\n\t'

 # Check if it's Ubuntu 18.04 or 20.04
+# I believe there is a lack of compatibility between using the -e and the following
+# code...
 lsb_release -d | grep -qi '18.04'; is_ubuntu_18=$?
 lsb_release -d | grep -qi '20.04'; is_ubuntu_20=$?
 if [ $is_ubuntu_18 -ne 0 -a $is_ubuntu_20 -ne 0 ]; then
mal-w commented 2 years ago

Obviously this causes other issues further on in the execution of the script on re-run... so it's not the correct solution... It was enough to get it to install the dependencies, but I think I would need to understand better what the failure is on the lines where the release is being checked...

luiscastilho commented 1 year ago

Hello! Sorry for the late reply. I'm making some changes to dungeoneering (adapting it to Processing 4) and if everything goes according to plan it will use a more recent version of GStreamer. If that works, this script shouldn't be needed anymore. I will update this issue when I get it working.