luisdalmolin / laravel-mandrill-driver

Mandrill mail driver for Laravel for version 6+
MIT License
79 stars 38 forks source link

Laravel 9.x Compatibility #26

Closed laravel-shift closed 2 years ago

laravel-shift commented 2 years ago

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 9.x.

Before merging, you need to:

If you do find an issue, please report it by commenting on this PR to help improve future automation.

laravel-shift commented 2 years ago

:alembic: Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/laravel-mandrill-driver.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "therobfonz/laravel-mandrill-driver": "dev-l9-compatibility",
    }
}

Finally, run: composer update

ankurk91 commented 2 years ago

Laravel 9 is no longer using swift mailer, but this package relies on it.

https://github.com/therobfonz/laravel-mandrill-driver/blob/master/src/MandrillTransport.php#L56

jasonmccreary commented 2 years ago

@ankurk91, are you saying this package will not support Laravel 9, or that there is more work to do?

therobfonz commented 2 years ago

@jasonmccreary Yeah, there needs to be an upgrade because the underlying mailer has changed.

I actually am looking for someone who wants to take care of this repository because I haven't used Mandrill in 2 years. Going to see if we want to move it under the Kirschbaum organization to maintain.

jasonmccreary commented 2 years ago

@therobfonz, gotcha. This really just bumps the dependencies. But let me know if I can help run some other automation around the Symfony Mailer. We do have that in the Laravel 9.x Shift.

jcanepa commented 2 years ago

@therobfonz @jasonmccreary FWIW I'd appreciate someone upgrading the underlying mailer. Thank you both for your contributions.

brandonferens commented 2 years ago

We have merged PR #28 for the Laravel 9 upgrade which address the underlying Symfony Mail change.