Rendering Offsets With Custom Model Data- Feature Request

luisdanieldlcg / BackTools

BackTools for Fabric. Shows the last used tool on the player's back. Purely aesthetic.

MIT License

8 stars 3 forks source link

Rendering Offsets With Custom Model Data- Feature Request #19

Open SpringToger opened 8 months ago

SpringToger commented 8 months ago

Is there anyway to get more options for offsets when it comes to configuring non-vanilla "tools"? In particular, custom model data items. Generally, things like sticks and bones are assigned custom model data to look like swords/bows. If we could have more customization of adding "items" to backtools, that would be great. If not, no worries! customclipping I wasn't sure if I should submit an issue for this, but I couldn't find any other contact. <3

luisdanieldlcg commented 8 months ago

Hello and thanks for submitting this issue.

Currently I don't have the time to work on more features on my own. However i don't have any problems if other contributors would like to see this feature in the mod. I'm going to ping the one that has helped me keeping the mod up to date in case he is able to help @FireInstall.

FireInstall commented 8 months ago

Could you be more specific about what you need? Then I can take a look into the code and tell you what is possible for me and what isn't.

Just make it customizable in the config or does it need to be ingame?
The belt or the back items or both?
Rotation around what axis?
Offset what directions?
Or do you need presets for something like bows...?
Anything else?

Please be reasonable - a yes to everything would be too much.

SpringToger commented 8 months ago

Sure!

Config options would be totally sufficient!
The issue for us is really just with the belt option.
It's less of rotation and more of shifting the item to be closer/further from the players side.
Either side of player (+/-), sort of like closer to their hip vs further away (side to side, not backwards and forwards).
No need for bows, they seem to offset correctly with custom model data!
Nope! Thank you so much! <3

FireInstall commented 8 months ago

Ok, I will add this to my todo list and report back soon™

FireInstall commented 8 months ago

I'm reporting back with a success: unofficial 1.20.4-1 I added an offset to the config, where you can optionally specify Nbt data. There you can add your CustomModel ID.

Please test and tell me your thoughts about it!

SpringToger commented 8 months ago

Sweet, this looks perfect!

I'm swamped with Uni so don't have much time to test atm....I'll get back to you ASAP!

Thanks again <3

FireInstall commented 5 months ago

With the new components of the 1.20.5 the syntax will be {"minecraft:custom_model_data": 1}

FireInstall commented 3 months ago

Well, any updates @SpringToger ?

SpringToger commented 3 months ago

So sorry, I completely forgot to reply!! This is perfect!! Thank you again!!

FireInstall commented 3 months ago

Nice, thank you for your suggestion and testing. Now we wait for @luisdanieldlcg to merge this.

If you need a 1.21 version say a word I just did update the rest of this mod.

SpringToger commented 3 months ago

Newer versions are always appreciated! No worries if you're busy!

FireInstall commented 3 months ago

Don't worry yourself, it was pretty fast to merge the two branches. Here you go: inoffical 1.21 + offsets