search

luisiam / homebridge-cmdswitch2

CMD Plugin for HomeBridge (API 2.0): https://github.com/nfarina/homebridge
Apache License 2.0
176 stars 29 forks source link

updateReachability and reachable property are deprecated, and removeAccessory is broken #56

Open palasinio opened 4 years ago

palasinio commented 4 years ago

https://github.com/homebridge/homebridge/issues/2459#issuecomment-614931368

While testing Homebridge Beta I was asked to inform you that your plugin may need some maintenance:

Please inform the plugin developer that the reachability feature (updateReachability and the reachable property) are deprecated since a long time and really aren't used for anything anymore. It will definitely be remove in a future release, but for now previous functionality is restored.
You can also inform them about the TypeError: Cannot read property 'context' of undefined and tell them that their removeAccessory is broken as the polling is not stopped for accessories which got removed.

Is this something ypu can fix?

Supereg commented 4 years ago

To give further context, when your plugin detects that an accessory needs to be removed, removeAccessory is called, but the polling interval is still ticking, and as the accessory doesn't exist anymore will constantly produce errors.