search

luisico / cert-manager-webhook-infoblox-wapi

InfoBlox WAPI webhook for cert-manager
Apache License 2.0
4 stars 8 forks source link

Allow setting TTL for the TXT records #6

Open dimatha opened 2 years ago

dimatha commented 2 years ago

Allow TXT TTL to be explicitly set in customDNSProviderConfig. In a situation where you want to extend an existing certificate and add an additional dnsNames (for example) and the default zone TTL is too high and certmanager is using "--dns01-recursive-nameservers", challenges will expire due to the old TXT challenges cached on the recursive DNS. This is where controlling the TTL via the Issue settings would become handy.

bb-Ricardo commented 2 months ago

added here: https://github.com/luisico/cert-manager-webhook-infoblox-wapi/pull/9

LsM97 commented 1 week ago

added here: #9

we had the same issue, however on the fork you created we get an issue when linitng/deploying:

[ERROR] templates/: template: cert-manager-webhook-infoblox-wapi/templates/rbac.yaml:5:11: executing "cert-manager-webhook-infoblox-wapi/templates/rbac.yaml" at <include "webhook.serviceAccountName" .>: error calling include: template: no template "webhook.serviceAccountName" associated with template "gotpl"

I am not entirely sure what is happening here however i am also not that keen with helm, bit it seems a bit is missin in the _helpers.tpl that fills the value for the serviceaccount. We tryed with ower own vluaes file, which worked on the original and the valuefile that came with the helmchart whithout modifying it. Any help on this issue is appreciated since we really want to use this to push dynammic updates to infoblox.

I would have created an issue on your fork however it seems i do not have the permission to do so.

Kind regards

bb-Ricardo commented 1 week ago

Hi,

Sorry, this was a mistake. I forgot to push the changes for the helm helper templates.

I added it and forced pushed a new commit which includes the missing templates.

can you try it again?

LsM97 commented 1 week ago

Hi,

works as intended, thats a lot for your work and fast response.

Kidnd regards,