luisllamasbinaburo / Arduino-Interpolation

Interpolation library for Arduino and similar
Apache License 2.0
35 stars 10 forks source link

publish v1.0.1 on PlatformIO #6

Closed 2bndy5 closed 8 months ago

2bndy5 commented 2 years ago

Any chance you can publish the v1.0.1 release on PlatformIO? I'm getting compiler warnings that should be fixed in that release, but I can't install it through PlatformIO lib registry (only v1.0.0 is available).

For completeness, here's the compiler warnings I'm seeing ``` .pio/libdeps/teensy41/InterpolationLib/src/InterpolationLib.cpp:10:114: warning: default argument given for parameter 5 of 'static double Interpolation::Step(double*, double*, int, double, double)' [-fpermissive] double Interpolation::Step(double xValues[], double yValues[], int numValues, double pointX, double threshold = 1) ^ In file included from .pio/libdeps/teensy41/InterpolationLib/src/InterpolationLib.cpp:8:0: .pio/libdeps/teensy41/InterpolationLib/src/InterpolationLib.h:66:16: note: previous specification in 'static double Interpolation::Step(double*, double*, int, double, double)' here static double Step(double xValues[], double yValues[], int numValues, double pointX, double threshold = 1); ^ .pio/libdeps/teensy41/InterpolationLib/src/InterpolationLib.cpp:24:112: warning: default argument given for parameter 5 of 'static double Interpolation::Linear(double*, double*, int, double, bool)' [-fpermissive] double Interpolation::Linear(double xValues[], double yValues[], int numValues, double pointX, bool trim = true) ^ In file included from .pio/libdeps/teensy41/InterpolationLib/src/InterpolationLib.cpp:8:0: .pio/libdeps/teensy41/InterpolationLib/src/InterpolationLib.h:70:16: note: previous specification in 'static double Interpolation::Linear(double*, double*, int, double, bool)' here static double Linear(double xValues[], double yValues[], int numValues, double pointX, bool trim = true); ^ .pio/libdeps/teensy41/InterpolationLib/src/InterpolationLib.cpp:56:116: warning: default argument given for parameter 5 of 'static double Interpolation::SmoothStep(double*, double*, int, double, bool)' [-fpermissive] double Interpolation::SmoothStep(double xValues[], double yValues[], int numValues, double pointX, bool trim = true) ^ In file included from .pio/libdeps/teensy41/InterpolationLib/src/InterpolationLib.cpp:8:0: .pio/libdeps/teensy41/InterpolationLib/src/InterpolationLib.h:72:16: note: previous specification in 'static double Interpolation::SmoothStep(double*, double*, int, double, bool)' here static double SmoothStep(double xValues[], double yValues[], int numValues, double pointX, bool trim = true); ^ .pio/libdeps/teensy41/InterpolationLib/src/InterpolationLib.cpp:75:119: warning: default argument given for parameter 5 of 'static double Interpolation::CatmullSpline(double*, double*, int, double, bool)' [-fpermissive] double Interpolation::CatmullSpline(double xValues[], double yValues[], int numValues, double pointX, bool trim = true) ^ In file included from .pio/libdeps/teensy41/InterpolationLib/src/InterpolationLib.cpp:8:0: .pio/libdeps/teensy41/InterpolationLib/src/InterpolationLib.h:73:16: note: previous specification in 'static double Interpolation::CatmullSpline(double*, double*, int, double, bool)' here static double CatmullSpline(double xValues[], double yValues[], int numValues, double pointX, bool trim = true); ^ .pio/libdeps/teensy41/InterpolationLib/src/InterpolationLib.cpp:131:123: warning: default argument given for parameter 5 of 'static double Interpolation::ConstrainedSpline(double*, double*, int, double, bool)' [-fpermissive] double Interpolation::ConstrainedSpline(double xValues[], double yValues[], int numValues, double pointX, bool trim = true) ^ In file included from .pio/libdeps/teensy41/InterpolationLib/src/InterpolationLib.cpp:8:0: .pio/libdeps/teensy41/InterpolationLib/src/InterpolationLib.h:74:16: note: previous specification in 'static double Interpolation::ConstrainedSpline(double*, double*, int, double, bool)' here static double ConstrainedSpline(double xValues[], double yValues[], int numValues, double pointX, bool trim = true); ^ ```

BTW, I think PIO lib registry stopped crawling existing libs for new updates, so you're probably going to have to automate releases from now on. I had to do this for the RF24 libs (requires a secret token generated by your PIO account).

2bndy5 commented 2 years ago

I also noticed you didn't bump the version number in your Arduino required library.properties: https://github.com/luisllamasbinaburo/Arduino-Interpolation/blob/bbeedd4671fa23c7765dbab1a75c7e8d782fa361/library.properties#L2 So, this latest release hasn't been distributed to the Arduino IDE library manager. image


I'm also not seeing a PIO specific library.json file to describe this lib for the PIO registry. Not sure if it is still required anymore...

freol35241 commented 2 years ago

+1

dgottstein commented 1 year ago

I'm having the same issues (for me it gives errors instead warnings for the esp32 compiler). Please upgrade to v1.0.1!

luisllamasbinaburo commented 8 months ago

See https://github.com/luisllamasbinaburo/Arduino-Interpolation/issues/10#issuecomment-1892346318