search

luismrsilva / cg-micromachines

3D version of the first MicroMachines game, made for the Computer Graphics course (2015/2016) at IST, CS BSc
1 stars 0 forks source link

Velas deveriam ser pointlight #47

Closed luismrsilva closed 8 years ago

luismrsilva commented 8 years ago

Diz no enunciado (parte 3) que a luz global deve ser spotlight e as velas pointlight. No entanto, a nossa classe LightSource é sempre spotlight. Sugiro tornar a classe LightSource abstracte criar as classes SpotLight e PointLight.

zettca commented 8 years ago

Pois, faz sentido a iluminação das velas ser PointLight (emite em todas as direções, diminui com a distância)!

luismrsilva commented 8 years ago

Fixed with 1f96e4b41a5ec37c73ab907b3df4d9eea7d6cda0.

luismrsilva commented 8 years ago

Falta LightSource ser abstract, but it's ok for now.