luismrsilva / cg-micromachines

3D version of the first MicroMachines game, made for the Computer Graphics course (2015/2016) at IST, CS BSc
1 stars 0 forks source link

Light state is sometimes inconsistent #53

Closed luismrsilva closed 8 years ago

luismrsilva commented 8 years ago

As of 6731196, LightSource::togglState() is not ideal. We need to use setState in order to make it consistent in an easier and more explicit way.

sofiaisreis commented 8 years ago

Solved with 0f1f0752532dc9093e2df2b0403ceed9c9c39291.

nuno-silva commented 8 years ago

@luismrsilva @sofiaisreis @zettca Pro tip: you guys should reference the issue number in the commit message instead of manually referencing the commit here. For instance, a commit message containing Did something. Fixes #53. will automatically close this issue and insert a reference to the commit here. See closing issues via commit message.

Here's a commit message of mine as an example:

'R' key restarts the game. Closes #66

- added GameManager::isGameOver()
- main.cpp catches 'R' key presses and:
  - deletes old GameManager
  - creates and inits a new one
  - calls its reshape function