Update edge.py - Githubissues

luispedro / mahotas

Computer Vision in Python

https://mahotas.rtfd.io

Other

846 stars 148 forks source link

Update edge.py #112

Open SujoyKG opened 4 years ago

SujoyKG commented 4 years ago

added edge detector based on Sujoy's algorithm

luispedro commented 4 years ago

Sorry for the delay, but this fails on travis (also, locally):

https://travis-ci.com/github/luispedro/mahotas/builds/170839189

luispedro commented 4 years ago

Also, this PR and #111 should be merged into one or does this one completely subsume the previous one?

SujoyKG commented 4 years ago

Sorry for the delay, but this fails on travis (also, locally):

https://travis-ci.com/github/luispedro/mahotas/builds/170839189

But what's the error Luis? I am not getting/clear... Please help.

SujoyKG commented 4 years ago

Also, this PR and #111 should be merged into one or does this one completely subsume the previous one?

These are the test cases

luispedro commented 4 years ago

The test cases should be with the code together in the same PR

But, in any case, the code does not even pass a smoke test: it mixes tabs & spaces.

SujoyKG commented 4 years ago

The test cases should be with the code together in the same PR

But, in any case, the code does not even pass a smoke test: it mixes tabs & spaces.

I will correct the space/tab errors & resubmit. But I am not sure how to put both (test case + function) together in one PR. Can you please help Luis?

luispedro commented 4 years ago

You can update PRs by adding commits to their respective branches. It does not need to be a single commit per PR.

coveralls commented 4 years ago

Coverage increased (+0.04%) to 97.449% when pulling 57e5245fa479d8ce6ecfb2dece69079e1c5b60fe on SujoyKG:patch-2 into 382fb2a94356b8b3ddab4caa0adc4461aade25b9 on luispedro:master.

SujoyKG commented 4 years ago

Hi Luis, "build" is complete on Travis. Added few more test-cases also. sorry for so many "commits"; as I am new to GITHUB. Thanks.

SujoyKG commented 3 years ago

Is there anything wrong, that you are not merging, Luis?

luispedro commented 3 years ago

Is this approach being used? I only saw your manuscript, but I did not find some citations and/or comments from users.

SujoyKG commented 3 years ago

I don't know who are using this. However this has got accepted in Julia Image Library (https://juliaimages.org/stable/examples/contours/sujoy_edge_demo/#Edge-detection-using-Sujoy-Filter) & also in the process of inclusion in a Java Image Library. Soon I shall copyright this. Thanks.