luizadauto / aionxemu

Automatically exported from code.google.com/p/aionxemu
6 stars 6 forks source link

NullPointerException #487

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Issues must affect Aion X Emu Files ONLY. Any revisions or altercations of
core files will not be supported here.

Core revision:
r333

Bug description:
NullPointerException

What steps will reproduce the problem?:
i don't know

What is the expected output?:
i don't know

Please copy/paste errors below:

[WARN 2011-07-05 20:32:37] 
com.aionemu.commons.utils.concurrent.ExecuteWrapper:57 - Exception in a 
Runnable execution:
java.lang.NullPointerException
    at gameserver.controllers.NpcController.onDie(NpcController.java:160)
    at quest.altgard._2232TheBrokenHoneyJar$1.run(_2232TheBrokenHoneyJar.java from JavaSourceFromFile:106)
    at com.aionemu.commons.utils.concurrent.ExecuteWrapper.execute(ExecuteWrapper.java:54)
    at com.aionemu.commons.utils.concurrent.ExecuteWrapper.run(ExecuteWrapper.java:39)
    at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
    at java.util.concurrent.FutureTask$Sync.innerRun(Unknown Source)
    at java.util.concurrent.FutureTask.run(Unknown Source)
    at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(Unknown Source)
    at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(Unknown Source)
    at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(Unknown Source)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
    at java.lang.Thread.run(Unknown Source)
[WARN 2011-07-05 20:33:00] 
com.aionemu.commons.utils.concurrent.ExecuteWrapper:57 - Exception in a 
Runnable execution:
java.lang.NullPointerException
    at gameserver.controllers.NpcController.onDie(NpcController.java:160)
    at quest.altgard._2232TheBrokenHoneyJar$1.run(_2232TheBrokenHoneyJar.java from JavaSourceFromFile:106)
    at com.aionemu.commons.utils.concurrent.ExecuteWrapper.execute(ExecuteWrapper.java:54)
    at com.aionemu.commons.utils.concurrent.ExecuteWrapper.run(ExecuteWrapper.java:39)
    at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
    at java.util.concurrent.FutureTask$Sync.innerRun(Unknown Source)
    at java.util.concurrent.FutureTask.run(Unknown Source)
    at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(Unknown Source)
    at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(Unknown Source)
    at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(Unknown Source)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
    at java.lang.Thread.run(Unknown Source)

Original issue reported on code.google.com by fb...@gmx.de on 6 Jul 2011 at 7:52

GoogleCodeExporter commented 8 years ago
Quests are sending a null to the creature's onDie(lastAttacker) event.

_2232TheBrokenHoneyJar.java, line 106:
 ((Npc) player.getTarget()).getController().onDie(null);
And in _2018ReconstructingImpetusium.java, line 128:
 npc.getController().onDie(null);

From NpcController.java, problem @ line 161:
 DropService.getInstance().registerDrop(getOwner(), (Player) lastAttacker, lastAttacker.getLevel());

Final parameter of registerDrop is making an object reference to a null object 
in this case.

Creating patch to correct this so that both quests send the proper player 
object.  Will require testing.

Original comment by geekswor...@gmail.com on 13 Jul 2011 at 1:32

GoogleCodeExporter commented 8 years ago

Original comment by pziko...@gmail.com on 21 Jul 2011 at 12:39