retpolanne commented 4 years ago

When we were developing the Ingress support for GCE, we thought the Ingress spec had to be different. However, after testing the same spec we create for Vhost for a couple of months, we found out that there was no problem in using it.

retpolanne commented 4 years ago

I believe it is safe to ignore Codecov for now, as the test that was deleted shouldn't affect the function coverage.

codecov-commenter commented 4 years ago

Codecov Report

Merging #626 into master will decrease coverage by 0.07%. The diff coverage is 41.66%.

@@            Coverage Diff             @@
##           master     #626      +/-   ##
==========================================
- Coverage   50.21%   50.14%   -0.08%     
==========================================
  Files          86       86              
  Lines        6199     6190       -9     
==========================================
- Hits         3113     3104       -9     
  Misses       2881     2881              
  Partials      205      205

Impacted Files	Coverage Δ
pkg/server/deploy/deploy.go	`74.86% <0.00%> (ø)`
pkg/server/k8s/client.go	`11.04% <0.00%> (ø)`
pkg/server/app/app.go	`69.67% <100.00%> (ø)`
pkg/server/k8s/converters.go	`87.67% <100.00%> (-0.30%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update edbf58c...cf37b5f. Read the comment docs.

luizalabs / teresa

This PR simplifies ingress #626

Codecov Report