luizalabs / teresa

Open source tool to deploy apps to Kubernetes clusters
Other
556 stars 77 forks source link

Ingress shouldn't be created for apps with empty Vhost #627

Closed retpolanne closed 4 years ago

retpolanne commented 4 years ago

If you toggle Ingress on a Teresa server deployment after some apps have been created without it, ingresses might be created without any host.

To replicate this bug:

  spec:
    rules:
    - http:
        paths:
        - backend:
            serviceName: myapp
            servicePort: 80
          path: /

Alternatively, the path can be a catch all /*, this way it'll work the same way as specify no rules.