luizalabs / teresa

Open source tool to deploy apps to Kubernetes clusters
Other
556 stars 79 forks source link

Checks if app already has ingress before trying to reserve a static IP #635

Closed retpolanne closed 4 years ago

retpolanne commented 4 years ago

This PR checks if the app has a Teresa managed ingress before trying to reserve a static IP.

Fixes #634

codecov-commenter commented 4 years ago

Codecov Report

Merging #635 into master will decrease coverage by 0.04%. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #635      +/-   ##
==========================================
- Coverage   50.52%   50.48%   -0.05%     
==========================================
  Files          86       86              
  Lines        6221     6224       +3     
==========================================
- Hits         3143     3142       -1     
- Misses       2865     2867       +2     
- Partials      213      215       +2     
Impacted Files Coverage Δ
pkg/server/deploy/deploy.go 73.86% <50.00%> (-1.65%) :arrow_down:
pkg/server/cloudprovider/gce.go 87.87% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a928cf5...fd6db9e. Read the comment docs.

retpolanne commented 4 years ago

@drgarcia1986 done!